Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getQuerystringSearchQuery doesn't accept path as an input #6301

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

askadityapandey
Copy link

This Pull Request fixes #6254 , which is "Without being able to pass in a path to the querystring-search, all searches are performed from the root, breaking relative queries (e.g. ../::1)"
I've added all the important tests which are required, also made it optional so it does not break for the existing users.
This is a cool project btw, will look forward to contribute more <3

@mister-roboto
Copy link

@askadityapandey you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 52b38b8
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66fa3cc46a897b0008b1a39e

@askadityapandey
Copy link
Author

askadityapandey commented Sep 20, 2024

@askadityapandey you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

Hey I did btw lmao. Mr.Bot

@mister-roboto
Copy link

@askadityapandey you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

@mister-roboto
Copy link

@askadityapandey you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

@mister-roboto
Copy link

@askadityapandey you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

@ichim-david
Copy link
Member

@askadityapandey @mister-roboto is a bot it won't take your comments into consideration.
Until the contributor agreement is settled this pull request can't be checked.
Read all of the steps again regarding contributions and make sure you have followed them.

@askadityapandey
Copy link
Author

@askadityapandey @mister-roboto is a bot it won't take your comments into consideration.
Until the contributor agreement is settled this pull request can't be checked.
Read all of the steps again regarding contributions and make sure you have followed them.

I was just playing with it lmao I know what is a bot. Also I signed it way before contribution. And read all the guidelines.

@ichim-david ichim-david removed their request for review September 20, 2024 18:38
@stevepiercy
Copy link
Collaborator

stevepiercy commented Sep 20, 2024

@askadityapandey if you don't get an invitation to join the Plone organization within a week after submitting your Plone Contributor Agreement, follow up with agreements@plone.org.

Also when you accept the invitation, please add a comment here to let others know that this is ready for review. Thank you!

@askadityapandey
Copy link
Author

askadityapandey commented Sep 25, 2024

@askadityapandey if you don't get an invitation to join the Plone organization within a week after submitting your Plone Contributor Agreement, follow up with agreements@plone.org.

Also when you accept the invitation, please add a comment here to let others know that this is ready for review. Thank you!

Hey, I've accepted the invitation.

@stevepiercy
Copy link
Collaborator

@askadityapandey you need to run linting locally. See https://6.docs.plone.org/volto/contributing/linting.html. This PR cannot be merged until it passes all CI checks.

packages/types/news/6254.feature Outdated Show resolved Hide resolved
packages/volto/news/6254.feature Outdated Show resolved Hide resolved
@stevepiercy
Copy link
Collaborator

@askadityapandey there is a failing test that needs to be addressed: https://github.com/plone/volto/actions/runs/11094962195/job/30823022269?pr=6301. Can you reproduce it locally, then apply a fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@plone/client: getQuerystringSearchQuery doesn't accept path as an input
4 participants