-
-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: getQuerystringSearchQuery doesn't accept path as an input #6301
base: main
Are you sure you want to change the base?
Conversation
@askadityapandey you need to sign the Plone Contributor Agreement to merge this pull request. Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement |
✅ Deploy Preview for plone-components canceled.
|
Hey I did btw lmao. Mr.Bot |
@askadityapandey you need to sign the Plone Contributor Agreement to merge this pull request. Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement |
@askadityapandey you need to sign the Plone Contributor Agreement to merge this pull request. Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement |
@askadityapandey you need to sign the Plone Contributor Agreement to merge this pull request. Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement |
@askadityapandey @mister-roboto is a bot it won't take your comments into consideration. |
I was just playing with it lmao I know what is a bot. Also I signed it way before contribution. And read all the guidelines. |
@askadityapandey if you don't get an invitation to join the Plone organization within a week after submitting your Plone Contributor Agreement, follow up with agreements@plone.org. Also when you accept the invitation, please add a comment here to let others know that this is ready for review. Thank you! |
Hey, I've accepted the invitation. |
@askadityapandey you need to run linting locally. See https://6.docs.plone.org/volto/contributing/linting.html. This PR cannot be merged until it passes all CI checks. |
@askadityapandey there is a failing test that needs to be addressed: https://github.com/plone/volto/actions/runs/11094962195/job/30823022269?pr=6301. Can you reproduce it locally, then apply a fix? |
This Pull Request fixes #6254 , which is "Without being able to pass in a path to the querystring-search, all searches are performed from the root, breaking relative queries (e.g. ../::1)"
I've added all the important tests which are required, also made it optional so it does not break for the existing users.
This is a cool project btw, will look forward to contribute more <3